Fix a bug when reaching the maximal size of pre-prepare#2716
Open
yontyon wants to merge 2 commits intovmware:masterfrom
Open
Fix a bug when reaching the maximal size of pre-prepare#2716yontyon wants to merge 2 commits intovmware:masterfrom
yontyon wants to merge 2 commits intovmware:masterfrom
Conversation
Contributor
yuliasherman
left a comment
yuliasherman
left a comment
There was a problem hiding this comment.
The fix looks correct, but it has to be tested using a unit test and/or Apollo test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reaching the limit of prePrepare message size we need to break the loop where we add requests. However, a bug was found where we compare the client message to the overall size before adding the requests causing to deletion of all extra client request messages.
CI