Skip to content

Reduce root trace generation to a minimum #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bayarcher wants to merge 1 commit into
base: v0.15.x
Choose a base branch
from
Open

Reduce root trace generation to a minimum #2757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion client/clientservice/src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ using concord::client::concordclient::ConcordClientConfig;
namespace po = boost::program_options;

const static int kLogConfigRefreshIntervalInMs = 60 * 1000;
const double kTraceSamplingRate = 0.000001;
static std::unique_ptr<ClientService> clientservice = nullptr;

const static char* getLog4CplusConfigLocation() {
Expand Down Expand Up @@ -90,7 +91,7 @@ class JaegerLogger : public jaegertracing::logging::Logger {

void initJaeger(const std::string& addr) {
// No sampling for now - report all traces
jaegertracing::samplers::Config sampler_config(jaegertracing::kSamplerTypeConst, 1.0);
jaegertracing::samplers::Config sampler_config(jaegertracing::kSamplerTypeConst, kTraceSamplingRate);
jaegertracing::reporters::Config reporter_config(jaegertracing::reporters::Config::kDefaultQueueSize,
jaegertracing::reporters::Config::defaultBufferFlushInterval(),
false /* false=don't log spans, true=JaegerUI */,
Expand Down
⚡