Skip to content

FullNode concord-bft changes#3001

Open
bandatarunkumar wants to merge 3 commits intovmware:masterfrom
bandatarunkumar:full_node_st_changes
Open

FullNode concord-bft changes#3001
bandatarunkumar wants to merge 3 commits intovmware:masterfrom
bandatarunkumar:full_node_st_changes

Conversation

@bandatarunkumar
Copy link
Copy Markdown
Contributor

  • Problem Overview
    This PR contains the necessary changes required for creating the fullnode replica in the vmbc.
  • Testing Done
    locally manual integration testing done

@bandatarunkumar bandatarunkumar self-assigned this Apr 25, 2023
@bandatarunkumar bandatarunkumar requested a review from a team as a code owner April 25, 2023 10:52
@bandatarunkumar bandatarunkumar force-pushed the full_node_st_changes branch 2 times, most recently from 6059ae8 to 7f96658 Compare April 26, 2023 12:41
Copy link
Copy Markdown
Contributor

@glevkovich glevkovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing comments in multiple reviews.

Comment thread bftengine/src/bcstatetransfer/BCStateTran.cpp
Comment thread bftengine/include/bcstatetransfer/SimpleBCStateTransfer.hpp
Comment thread bftengine/include/bcstatetransfer/SimpleBCStateTransfer.hpp Outdated
Comment thread bftengine/src/bftengine/ClientsManager.cpp Outdated
Comment thread bftengine/src/bftengine/FullNodeReplica.cpp Outdated
Comment thread bftengine/src/bftengine/FullNodeReplica.cpp
Comment thread bftengine/src/bftengine/FullNodeReplica.cpp Outdated
Comment thread bftengine/src/bftengine/FullNodeReplica.cpp
Comment thread bftengine/src/bftengine/FullNodeReplica.cpp
Comment thread bftengine/src/bftengine/FullNodeReplica.cpp
Comment thread bftengine/src/bftengine/FullNodeReplica.cpp
Comment thread bftengine/src/bftengine/FullNodeReplica.cpp
Comment thread bftengine/src/bftengine/FullNodeReplica.cpp
Comment thread bftengine/src/bftengine/FullNodeReplica.cpp Outdated
Comment thread bftengine/src/bftengine/FullNodeReplica.hpp
Comment thread bftengine/src/bftengine/FullNodeReplica.hpp
Comment thread bftengine/src/bftengine/FullNodeReplica.hpp Outdated
Comment thread bftengine/src/bftengine/FullNodeReplica.hpp
Comment thread bftengine/src/bftengine/ReadOnlyReplica.hpp Outdated
Comment thread bftengine/src/bftengine/ReplicaFactory.cpp
Comment thread bftengine/src/bftengine/ReplicaImp.hpp Outdated
@bandatarunkumar bandatarunkumar force-pushed the full_node_st_changes branch 2 times, most recently from c652cfb to c1204d4 Compare May 8, 2023 17:39
@bandatarunkumar bandatarunkumar force-pushed the full_node_st_changes branch from c1204d4 to 2fc0603 Compare May 8, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants