fix: change controllerKey and unitNumber to *int32#3880
Merged
tenthirtyam merged 1 commit intovmware:mainfrom Oct 8, 2025
Merged
fix: change controllerKey and unitNumber to *int32#3880tenthirtyam merged 1 commit intovmware:mainfrom
controllerKey and unitNumber to *int32#3880tenthirtyam merged 1 commit intovmware:mainfrom
Conversation
8447b3b to
05c18f4
Compare
Contributor
|
CI is faling on the DCO - commits need to be signed. |
controllerKey and unitNumber to int32
tenthirtyam
requested changes
Oct 6, 2025
Contributor
tenthirtyam
left a comment
There was a problem hiding this comment.
Can you open an issue and link the issue to this pull request for traceability?
4edb815 to
cf47f95
Compare
controllerKey and unitNumber to int32controllerKey and unitNumber to int32
Contributor
Author
|
@tenthirtyam I have addressed your comments. |
controllerKey and unitNumber to int32controllerKey and unitNumber to int32
tenthirtyam
approved these changes
Oct 6, 2025
controllerKey and unitNumber to int32controllerKey and unitNumber to *int32
tenthirtyam
requested changes
Oct 6, 2025
Contributor
There was a problem hiding this comment.
@skogta - please sign-off with your @broadcom.com email instead of legacy @vmware.com.
prziborowski
reviewed
Oct 6, 2025
cf47f95 to
38400cd
Compare
Signed-off-by: Saloni Kogta <saloni.kogta@broadcom.com>
38400cd to
7e776e0
Compare
Contributor
Author
|
@prziborowski @tenthirtyam can I please get an approval? I have addressed your comments. |
tenthirtyam
reviewed
Oct 7, 2025
tenthirtyam
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change the type if controllerKey and unitNumber to *int32 in CnsVolumeAttachDetachSpec.
Closes: #3883
How Has This Been Tested?
Complete govmomi testing logs:
Testing.rtf
CNS logs for attaching disk with controllerKey and UnitNumber:
CNS logs for attaching disk without shared disk params:
Guidelines
Please read and follow the
CONTRIBUTIONguidelines of this project.