Skip to content

update peer dependency for svelte 4#197

Merged
vnphanquang merged 1 commit into
vnphanquang:mainfrom
saadeghi:patch-1
Jul 3, 2023
Merged

update peer dependency for svelte 4#197
vnphanquang merged 1 commit into
vnphanquang:mainfrom
saadeghi:patch-1

Conversation

@saadeghi
Copy link
Copy Markdown
Contributor

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 30, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @vnphanquang on Vercel.

@vnphanquang first needs to authorize it.

@vnphanquang
Copy link
Copy Markdown
Owner

@saadeghi thank you. Sorry, update to support Svelte 4 is in my todo list but I'm too caught up with work currently. Will do soon

@saadeghi
Copy link
Copy Markdown
Contributor Author

@vnphanquang Looks like everything works fine already. The package works with Svelte 4 but I need to use --legacy-peer-deps flag everytime because of the peer dependency

@vnphanquang
Copy link
Copy Markdown
Owner

Yeah, that's expected, and annoying for sure. I'm planning to align migration to vanilla JS with the next release. But perhaps i should hold that off and do a patch for Svelte peer dependency update.

@brandonp-ais
Copy link
Copy Markdown

I'm planning to align migration to vanilla JS with the next release.

Like svelte/kit? That'd be cool.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-put ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 2:08am

@vnphanquang
Copy link
Copy Markdown
Owner

@brandonp-ais yes, svelte team really opens up my mind about the benefits of vanilla JS, and they align very well with svelte-put packages

@vnphanquang
Copy link
Copy Markdown
Owner

Note: added same peer dependency re-config to all packages; added changeset

@vnphanquang vnphanquang merged commit 4b1fe72 into vnphanquang:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants