refactor(toc): Use Map instead of object#270
Merged
vnphanquang merged 4 commits intoJan 12, 2024
Merged
Conversation
vnphanquang
force-pushed
the
refactor/toc-use-map-instead-of-object
branch
from
639b571 to
fb386d9
Compare
Owner
|
rebase with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #269
There is a problem with numeric headers not being correctly ordered on the table of contents, a solution I found was to use a
Mapinstead of an object. I don't know if it's an issue that you guys want to have solved, but I'm having a problem with it in my project.This PR changes the implementation to use a Map, and also changes the docs to the new way of rendering.
Changes
Map<string, TocItem>.toc.