Skip to content

Allow Pyo3 0.25#64

Merged
vorner merged 3 commits intovorner:mainfrom
a1phyr:pyo3_0.25
May 18, 2025
Merged

Allow Pyo3 0.25#64
vorner merged 3 commits intovorner:mainfrom
a1phyr:pyo3_0.25

Conversation

@a1phyr
Copy link
Copy Markdown
Contributor

@a1phyr a1phyr commented May 14, 2025

No description provided.

@vorner
Copy link
Copy Markdown
Owner

vorner commented May 15, 2025

Hello

I'm all for the part of allowing newer pyo3.

I'm a bit split on bumping the minimal version. Is there a good motivation to do so?

And, is there a good reason why you're changing the provider of the toolchain for the CI? Did the actions-rs stop working, or something?

@a1phyr
Copy link
Copy Markdown
Contributor Author

a1phyr commented May 15, 2025

I'm a bit split on bumping the minimal version. Is there a good motivation to do so?

Well, 1.63 is the MSRV of pyo3 since 0.22, so it makes sense to require it too.

And, is there a good reason why you're changing the provider of the toolchain for the CI? Did the actions-rs stop working, or something?

Technically it still works, but it uses deprecated API (eg see warnings at the end of this action run) and has been archived since october 2023. I used dtolnay/rust-toolchain instead because it is used in the other jobs.

@vorner vorner merged commit ea2af44 into vorner:main May 18, 2025
60 checks passed
@vorner
Copy link
Copy Markdown
Owner

vorner commented May 18, 2025

Thanks, that explanation makes sense. I've merged it and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants