Support uppercase configuration environment variables#117
Merged
bastelfreak merged 1 commit intovoxpupuli:masterfrom Mar 24, 2023
Merged
Support uppercase configuration environment variables#117bastelfreak merged 1 commit intovoxpupuli:masterfrom
bastelfreak merged 1 commit intovoxpupuli:masterfrom
Conversation
smortex
approved these changes
Feb 21, 2023
Member
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
Lowercase in environment variables is awkward and inconsistent with the rest of the tooling I am used to on UNIX-like OS. +1 for this!
This changes the preferred usage of BEAKER_x to BEAKER_X, so BEAKER_DESTROY instead of BEAKER_destroy. The old names are still supported.
bastelfreak
force-pushed
the
support-upper-case-vars
branch
from
9284acc to
7b7edb5
Compare
bastelfreak
changed the title
smortex
added a commit
to voxpupuli/voxpupuli.github.io
that referenced
this pull request
Jul 12, 2023
Follow-up of: voxpupuli/beaker-rspec#117 The old names or still supported but for consistency change them to the new ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the preferred usage of BEAKER_x to BEAKER_X, so BEAKER_DESTROY instead of BEAKER_destroy. The old names are still supported.