Use beaker-hostgenerator for docker acceptance tests

[ekohl]

Depends on voxpupuli/beaker-hostgenerator#109 and will require changes to modules with docker tests. Also allows removal of the files in the actual containers.

It'd be nice if we could also push the EC2 and vagrant boxes into beaker-hostgenerator.

• Rely on beaker-hostgenerator for docker nodesets puppet-autofs#118
• Rely on beaker-hostgenerator for docker nodesets puppet-bird#11
• Rely on beaker-hostgenerator for docker nodesets puppet-collectd#791
• Rely on beaker-hostgenerator for docker nodesets puppet-corosync#441
• Rely on beaker-hostgenerator for docker nodesets puppet-gluster#166
• Rely on beaker-hostgenerator for docker nodesets puppet-grafana#108
• Rely on beaker-hostgenerator for docker nodesets puppet-jira#246
• Rely on beaker-hostgenerator for docker nodesets puppet-lldpd#44
• Rely on beaker-hostgenerator for docker nodesets puppet-nginx#1216
• Rely on beaker-hostgenerator for docker nodesets puppet-nodejs#367
• Rely on beaker-hostgenerator for docker nodesets puppet-nscd#37
• Rely on beaker-hostgenerator for docker nodesets puppet-php#452
• Rely on beaker-hostgenerator for docker nodesets puppet-prometheus#190
• Rely on beaker-hostgenerator for docker nodesets puppet-puppetboard#212
• Rely on beaker-hostgenerator for docker nodesets puppet-rabbitmq#702
• Rely on beaker-hostgenerator for docker nodesets puppet-report_hipchat#36
• Rely on beaker-hostgenerator for docker nodesets puppet-rsyslog#79
• Rely on beaker-hostgenerator for docker nodesets puppet-rundeck#376
• Rely on beaker-hostgenerator for docker nodesets puppet-splunk#181
• Rely on beaker-hostgenerator for docker nodesets puppet-squid#96
• Rely on beaker-hostgenerator for docker nodesets puppet-yum#98
• Rely on beaker-hostgenerator for docker nodesets puppet-zabbix#498

[vinzent]

Good move to use beaker-hostgenerator.

I do miss however documentation if something changes when someone wants invoke beaker.

And where are these docker_image_commands now ? are they default in beaker-hostgenerator ?

[ekohl]

I do miss however documentation if something changes when someone wants invoke beaker.

I'm waiting to see how the beaker-hostgenerator PR turns out. Right now you replace BEAKER_nodeset=docker/centos-7 with BEAKER_setfile=centos7-64{hypervisor=docker} but I'm considering a PR for to set the hypervisor via an env var. Sadly the invocation is a bit spread over beaker.

And where are these docker_image_commands now ? are they default in beaker-hostgenerator ?

Yes. I'm hoping that our defaults are good enough defaults for the entire community :)

[ekohl]

Updated now that the beaker-hostgenerator change was released. See voxpupuli/puppet-autofs#118 for an example that is now required for every module that uses docker_sets. We also need to git rm -r spec/acceptance/nodesets/docker in every module when syncing since modulesync can't remove old files.

[ekohl]

Updated. I submitted a bunch of PRs (linked) for the modules that actually use docker_sets. For other modules I've some commits ready that purge the files and clean up .sync.yml for windows modules which had the docker files marked as unmanaged. When this is merged I'll submit those.