Use voxpupuli-acceptance#647
Merged
ekohl merged 1 commit intovoxpupuli:masterfrom Apr 7, 2020
Merged
Conversation
Member
Author
|
Hold off, I messed up and wiped a lot of my changes accidentally. |
Member
Author
|
Luckily I made a backup branch before I started the dangerous operations. Pushing fixed versions again and should be ready for review. |
ekohl
force-pushed
the
voxpupuli-acceptance
branch
from
716ce37 to
e65ec6f
Compare
ekohl
commented
Apr 6, 2020
Member
Author
|
@dhollinger this is inspired by what you said: we shouldn't template the spec acceptance helper. It doesn't, but provides a way to trivially do for trivial helpers. I'd be interested in what you think. This is also where I think https://github.com/voxpupuli/voxpupuli-test should be in an ideal world, but there's too much variation in that file that I haven't been able to trim just yet. |
bastelfreak
approved these changes
Apr 7, 2020
This moves a lot of logic from modulesync into a gem. This greatly reduces the amount of code we have to sync. It also starts to manage spec_acceptance_helper.rb in various modules when they only need a trivial helper.
ekohl
force-pushed
the
voxpupuli-acceptance
branch
from
e65ec6f to
99eb60e
Compare
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves a lot of logic from modulesync into a gem. This greatly reduces the amount of code we have to sync. It also starts to manage spec_acceptance_helper.rb in various modules when they only need a trivial helper.