Improve datatypes#219
Conversation
alexjfisher
left a comment
alexjfisher
left a comment
There was a problem hiding this comment.
Looks mostly correct. Dns search domains is probably the only thing that needs to be changed.
| Stdlib::Port $ldap_port = 389, | ||
| String[1] $ldap_server = 'localhost', | ||
| String[1] $ldap_username = 'cn=root, dc=example, dc=com', | ||
| String[0] $ldap_password = '', |
There was a problem hiding this comment.
the default is an empty string and I didn't want to change it. Personally I wuld perfer undef. Do you want me to change it? That would be a breaking change (next release already is a major one, so we could include it).
There was a problem hiding this comment.
I meant why not leave it as String
There was a problem hiding this comment.
ah yes. doesn't make a difference
| Array[Stdlib::Fqdn] $dnssearchdomains = [], | ||
| String[1] $dhcp_conf_header = 'INTERNAL_TEMPLATE', | ||
| String[1] $dhcp_conf_ddns = 'INTERNAL_TEMPLATE', | ||
| String[1] $dhcp_conf_ntp = 'INTERNAL_TEMPLATE', |
There was a problem hiding this comment.
Are empty strings definitely not allowed here?
There was a problem hiding this comment.
allowed empty string again
| Enum['allow', 'deny'] $ddns_client_updates = 'allow', | ||
| Optional[Stdlib::IP::Address] $pxeserver = undef, | ||
| Optional[String[1]] $pxefilename = undef, | ||
| Optional[Integer[1]] $mtu = undef, |
There was a problem hiding this comment.
An MTU of 1 is no more valid than 0
There was a problem hiding this comment.
I'm not sure which is the lowest positive number that makes sense, I just wanted to prohibit negative numbers.
bastelfreak
force-pushed
the
types
branch
3 times, most recently
from
1be5691 to
44b810e
Compare
2 participants
Pull Request (PR) description
This Pull Request (PR) fixes the following issues