certain `dbconfig.xml` settings require `enable_connection_pooling => true`

[ronech]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 5.4.0
• Ruby: 2.4.3p205
• Distribution:
• Module version: 3.3.0

How to reproduce (e.g Puppet code you use)

What are you seeing

Some of the postgresql DB settings in dbconfig.xml depend on enable_connection_pooling being set to true. This isn't reflected in README.md, so i was puzzled when my changes were being ignored.

What behaviour did you expect instead

Output log

Any additional information you'd like to impart

Here's my git diff output as i'm unable to push my branch.

diff --git a/README.md b/README.md
index abaf285..37364a6 100644
--- a/README.md
+++ b/README.md
@@ -262,47 +262,47 @@ Configure database settings if you are pooling connections, defaults to 'false'

 ##### `$pool_min_size`

-defaults to 20
+defaults to 20 (requires `enable_connection_pooling => true`)

 ##### `$pool_max_size`

-defaults to 20
+defaults to 20 (requires `enable_connection_pooling => true`)

 ##### `$pool_max_wait`

-defaults to 30000
+defaults to 30000 (requires `enable_connection_pooling => true`)

 ##### `$validation_query`

-defaults to undef
+defaults to undef (requires `enable_connection_pooling => true`)

 ##### `$min_evictable_idle_time`

-defaults to 60000
+defaults to 60000 (requires `enable_connection_pooling => true`)

 ##### `$time_between_eviction_runs`

-defaults to undef
+defaults to undef (requires `enable_connection_pooling => true`)

 ##### `$pool_max_idle`

-defaults to 20
+defaults to 20 (requires `enable_connection_pooling => true`)

 ##### `$pool_remove_abandoned`

-defaults to true
+defaults to true (requires `enable_connection_pooling => true`)

 ##### `$pool_remove_abandoned_timeout`

-defaults to 300
+defaults to 300 (requires `enable_connection_pooling => true`)

 ##### `$pool_test_while_idle`

-defaults to true
+defaults to true (requires `enable_connection_pooling => true`)

 ##### `$pool_test_on_borrow`

-defaults to false
+defaults to false (requires `enable_connection_pooling => true`)

 #### MySQL Java Connector parameters