Add Support for H2 Database and Fix #73 #256
Conversation
TJM
changed the title
Also Fix voxpupuli#73 - Set appropriate defaults for dbtype and dbdriver based on db.
| $dbdriver = 'org.postgresql.Driver', | ||
| $dbtype = 'postgres72', | ||
| $dburl = undef, | ||
| Optional[Variant[Integer,String]] $dbport = undef, |
There was a problem hiding this comment.
For what its worth, I was tempted to use Optional[Stdlib::Port::Unprivileged], but was afraid I would break existing configurations for folks who insist on quoting numbers like '3306', so while this doesn't have as much validation, it was at least "backwards" compatible :)
| @@ -0,0 +1,23 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
could you convert this to an epp() template please?
There was a problem hiding this comment.
I figured consistency is better, otherwise we have to convert all the templates to EPP, and if we bother doing that, we should just make it one template and conditionally include the lines as needed instead of having several files that are almost exactly the same.
There was a problem hiding this comment.
ah good point, let's keep it as is.
bastelfreak
added
bug
|
Hi @TJM, thanks for the PR! Can you please take a look at the inline comment I made? |
bastelfreak
changed the title
2 participants
Pull Request (PR) description
Add Support for H2 database and add sensible defaults for other db related params.
This Pull Request (PR) fixes the following issues
Fixes #254
Fixes #73