Skip to content

Added relaxedPath xml attributes as per jira apache tomcat upgrade file#280

Merged
bastelfreak merged 2 commits intovoxpupuli:masterfrom
domgoodwin:master
Feb 19, 2019
Merged

Added relaxedPath xml attributes as per jira apache tomcat upgrade file#280
bastelfreak merged 2 commits intovoxpupuli:masterfrom
domgoodwin:master

Conversation

@domgoodwin
Copy link
Copy Markdown
Contributor

Notes:
https://confluence.atlassian.com/jirasoftware/jira-software-7-13-x-upgrade-notes-957135908.html

Pull Request (PR) description

Add relaxedPath attributes into tomcat config to support Jira 7.13+

Comment thread templates/server.xml.erb Outdated
@vrmerlin
Copy link
Copy Markdown

vrmerlin commented Feb 13, 2019

I hope this can be added soon -- it's preventing me from doing any upgrades (including the new 8.0 that just came out).

@bastelfreak
Copy link
Copy Markdown
Member

@vrmerlin the tests are failing on this one, we cannot merge it. But you can always checkout the branch, update it, and provide it as another PR.

@vrmerlin
Copy link
Copy Markdown

@bastelfreak Yes, I understand. I wasn't the original person who made the pull request, so i didn't want to step on Dom's toes if he was working on it.

@domgoodwin are you working on a fix to the PR?

@domgoodwin
Copy link
Copy Markdown
Contributor Author

Honestly I wasn't sure on the issues raised from the Travis CI build. @vrmerlin feel free to update 👍

@vrmerlin
Copy link
Copy Markdown

No idea what i'm doing either, but I'll play around with it.

@vrmerlin
Copy link
Copy Markdown

vrmerlin commented Feb 13, 2019

@domgoodwin the failure I'm seeing is this:

is_expected.to contain_file('/opt/jira/atlassian-jira-6.3.4a-standalone/conf/server.xml').
   with_content(%r{<Connector port=\"9229\"\s+address=\"127\.0\.0\.1\"\s+maxThreads=}m)

I think all you need to do is move your two "relaxedPathChars" entries down further in the list, past the maxThreads, so that this rule still passes. Can you make that change? It might go a lot faster that way.

@vrmerlin
Copy link
Copy Markdown

vrmerlin commented Feb 13, 2019

It passed all the tests now!! :-) Thanks for the second fix, @domgoodwin .

@bastelfreak Can this be approved and merged now? I'm giving a demo to another team in a few days, on how easy a JIRA upgrade is...

@domgoodwin
Copy link
Copy Markdown
Contributor Author

Thanks for the assistance spotting that issue @vrmerlin 🥇

@vrmerlin
Copy link
Copy Markdown

@bastelfreak FYI, I pulled down @domgoodwin 's branch, and used it to do an upgrade to JIRA 8.0, and it worked great!

@bastelfreak bastelfreak added the enhancement New feature or request label Feb 19, 2019
@bastelfreak
Copy link
Copy Markdown
Member

thanks everybody!

@bastelfreak bastelfreak merged commit 6f63f11 into voxpupuli:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants