Allow specifying JDBC connection parameters with jira::connection_settings#353
Merged
oranenj merged 2 commits intovoxpupuli:masterfrom Apr 14, 2021
Merged
Conversation
ekohl
reviewed
Apr 13, 2021
| 'h2' => '5000', | ||
| } | ||
|
|
||
| $dbschema = if $jira::dbschema { $jira::dbschema } else { $dbschema_default } |
Member
There was a problem hiding this comment.
Is this because pick doesn't work with undef? Perhaps that deserves a note.
Contributor
Author
There was a problem hiding this comment.
I'll add it to the other PR; the first commit in this one is just because this depends on #352, so you can ignore that while reviewing.
oranenj
force-pushed
the
connection-params
branch
from
b8306aa to
ae0e7c6
Compare
bastelfreak
approved these changes
Apr 14, 2021
most other related variables don't have any kind of prefix either so neither will this
oranenj
force-pushed
the
connection-params
branch
from
ae0e7c6 to
f2c7be7
Compare
Contributor
Author
|
I renamed the parameter and added a spec test, let's see if I got it right. |
oranenj
force-pushed
the
connection-params
branch
from
0159bae to
6864ddd
Compare
oranenj
changed the title
Contributor
Author
|
I'll just merge this; if someone wants to bikeshed parameter naming, there's still time before release. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-jira
that referenced
this pull request
Oct 13, 2021
Allow specifying JDBC connection parameters with jira::connection_settings
cegeka-jenkins
pushed a commit
to cegeka/puppet-jira
that referenced
this pull request
Sep 1, 2025
Allow specifying JDBC connection parameters with jira::connection_settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs the dbconfig refactoring PR first. Adds an API to control JDBC connection parameters.