Allow custom plugin installation and usage of JNDI database connections

[ThomasMinor]

Pull Request (PR) description

Added feature to install custom plugins and use JNDI database connections

This Pull Request (PR) fixes the following issues

n/a

[root-expert]

Hello! Thanks for your conribution!

Take a look at the inline comments I left. If you need any help you can contact us on the #voxpupuli channel on Libera.Chat IRC or on Puppet's Slack (same channel)

[ThomasMinor]

Hi there, does anyone have a hint how to eliminate the one failing test on CentOS 7? Maybe a good document about running the tests locally?

[kenyon]

Hi there, does anyone have a hint how to eliminate the one failing test on CentOS 7? Maybe a good document about running the tests locally?

Docs on running tests can be found here: https://github.com/voxpupuli/puppet-jira/blob/master/.github/CONTRIBUTING.md

[root-expert]

Hey @ThomasMinor took a look at the output of the tests. Sadly we have seen this error before. The current workaround is to add these 2 lines in our pipeline.

[ThomasMinor]

Hi @root-expert, I followed your advice to add the workaround and the tests succeeded - Thanks!
I just have a few questions now...

• How did You identified the LANG settings as the cause of the problem from the logged messages?
• Isn't isn't it a bad idea to modify the ci.yml file due to the modulesync management?

[root-expert]

• How did You identified the LANG settings as the cause of the problem from the logged messages?

The error was Error: /Stage[main]/Postgresql::Server::Reload/Exec[postgresql_reload]: invalid byte sequence in US-ASCII

bastelfreak had deployed that workaround in the past for puppet-zabbix so it was known to me 😄

• Isn't isn't it a bad idea to modify the ci.yml file due to the modulesync management?

Yes it will be overwritten, we manually add it back when we are modulesyncing.
There's some discussion here regarding the issue btw.

[root-expert]

Not a user of the module but seems okay to me

[root-expert]

Can you squash you commits before merging?