Skip to content

refactored module.#4

Merged
brycejohnson merged 1 commit intovoxpupuli:masterfrom
mkrakowitzer:master
Aug 25, 2013
Merged

refactored module.#4
brycejohnson merged 1 commit intovoxpupuli:masterfrom
mkrakowitzer:master

Conversation

@mkrakowitzer
Copy link
Copy Markdown
Contributor

Updated module to use parametrized class, now uses Hiera data bindings.

This removes the dependencies on Hiera and puppet 3, obviously you can still use Hiera.

Lots of random changes,

I have tested on Ubuntu 12.04, RHEL 6.4, Centos 5.9.

@ghost ghost assigned brycejohnson Jun 29, 2013
@mkrakowitzer
Copy link
Copy Markdown
Contributor Author

Hi Bryce.

The dependencies are still there, but on the Linux systems that I have tested on using the puppet repositories the dependencies auto resolve. Even installing puppet via gem will resolve all the must have gem dependencies.

My suggestion would be to cherry pick what makes sense in this pull request. As an example you may not want to use my deploy module. We install many atlassian products via .tar.gz files, so it made sense for us to rather have a module to do it. However we are now actually in favour of packaging the atlassian tar files as .deb and .rpm and installing them that way via a repository. Perhaps you should kill this pull request and I can submit an updated one which handles the tarball way and the package management way with some other minor updates.

I do strongly recommend using parameterized classes, it seems to be the recommended way these days.

brycejohnson added a commit that referenced this pull request Aug 25, 2013
@brycejohnson brycejohnson merged commit cfdc626 into voxpupuli:master Aug 25, 2013
diLLec pushed a commit to diLLec/puppet-jira that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants