Fix breaking change regression of PR #429

[diLLec]

Pull Request (PR) description

Optimization for PR Add "change database password" parameter - JIRA >10.3

This Pull Request (PR) fixes the following issues

• make change_dbpassword only be effective after version 10.3.0
• add tests

[diLLec]

I really tried to add an acceptance test for JIRA 10.3.3 but I think we would need to limit those to certain modern OS versions like CentOS 9. Otherwise the prerequisites on MySQL and JAVA Version would not be able to be met. Unfortunately, I don't know how to limit the acceptance tests to a certain OS. If someone knows, please contact me.

[SimonHoenscheid]

@diLLec looks good to me. I asked for two other reviewers

[SimonHoenscheid]

@diLLec can you sqash your commits so there is just one? I think most commits can be fixups.

git rebase -i HEAD~13 should initiate the rebase

[bastelfreak]

@diLLec thanks for the PR. As you mentioned, I think an acceptance test makes sense. https://github.com/voxpupuli/puppet-nodejs/blob/master/spec/acceptance/class_spec.rb#L38 has an example of limiting a test to specific operating systems. Does that help you?

[kenyon]

We can squash commits on merge.

[h-haaks]

The title of this pull request ends up in the change log.
Could you change the title to better address the fact that this fixes a regression introduced in #429 ?

[h-haaks]

There is another regression as well.

when provisioning jira 10.3.x on a fresh server without specifying change_dbpassword = true, the password ends up being set to {ATL_SECURED} before the first server startup.

Solving this regression requires implementing some facts to figure out if jira is already installed or not.
It's probably best to address this in another issue/pull request.

[diLLec]

After a day of testing and learning I finally managed to bring the acceptance test and the facts to work. Please review again. Locally the acceptance tests are building fine with debian11-64 and almalinux8-64 and almalinux9-64

[SimonHoenscheid]

Can we merge this Change?

[vchepkov]

I would pass a path to the config file instead of relying on user's home.
manifest uses jira::homedir, imho, that should be used

[bastelfreak]

I have some questions here. Why does that even break the exec resource? And is that a patch that should be added to the postgresql module instead?

[diLLec]

This I've copied from the existing default_parameters_spec.rb. I don't know if it is still needed.

[diLLec]

I would pass a path to the config file instead of relying on user's home. manifest uses jira::homedir, imho, that should be used

OK - added that

[diLLec]

From my point of view, this MR can be merged: all tests are OK and all the requested changes are included.

[rwaffen]

okay, nice, just was looking for this change 😃 will merge and release