Fix compilation failures on RHEL when manage_package => true#431
Merged
bastelfreak merged 5 commits intovoxpupuli:masterfrom Dec 21, 2017
weareact:fix_430
Merged
Fix compilation failures on RHEL when manage_package => true#431bastelfreak merged 5 commits intovoxpupuli:masterfrom weareact:fix_430
manage_package => true#431bastelfreak merged 5 commits intovoxpupuli:masterfrom
weareact:fix_430
Conversation
…heck 'manage_package => true' compilation.
bastelfreak
reviewed
Dec 21, 2017
| create_admin: true, | ||
| admin_username: 'admin', | ||
| admin_password: 'password' | ||
| on_supported_os.each do |os, facts| |
bastelfreak
reviewed
Dec 21, 2017
| describe 'mongodb::server' do | ||
| let :facts do | ||
| # Default facts | ||
| let(:default_facts) do |
Member
There was a problem hiding this comment.
this block shouldnt be needed. We already mock this fact here: https://github.com/voxpupuli/puppet-mongodb/blob/master/spec/default_module_facts.yml
Contributor
Author
There was a problem hiding this comment.
Ah, that's a useful method to know, as we have a number of occurrences of this on internal module tests...
Contributor
Author
|
And we're green! @bastelfreak Did you want me to squash the commits down? |
fatmcgav
changed the title
manage_package => truemanage_package => true
Member
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #430
TODO: