Add check if scram credentials are insync with hash#455
Merged
bastelfreak merged 3 commits intovoxpupuli:masterfrom Mar 28, 2018
Merged
Add check if scram credentials are insync with hash#455bastelfreak merged 3 commits intovoxpupuli:masterfrom
bastelfreak merged 3 commits intovoxpupuli:masterfrom
Conversation
For mongodb >3 the auth mechanism SCRAM-SHA-1 is the new default. This adds a util and check if the keys computed by password_hash, salt and iterationCount matches the keys of the existing user.
bastelfreak
added
enhancement
Member
|
Thanks for the PR @ctrox ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
For mongodb >3 the auth mechanism SCRAM-SHA-1 is the new default.
This adds a util and check if the keys computed by password_hash,
salt and iterationCount matches the keys of the existing user.
How SCRAM-SHA-1 works is described here: https://www.mongodb.com/blog/post/improved-password-based-authentication-mongodb-30-scram-explained-part-1
The test I have added is really basic, please let me know if and how this could be improved. Also the scram_credentials parameter is "read-only" which is just done via validate. Looking at other types in the puppet source this is usually how they are dealt with.
This Pull Request (PR) fixes the following issues
Fixes #425