Skip to content

Deduplicate & update params.pp #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ekohl merged 1 commit into from
Oct 20, 2018
Merged

Deduplicate & update params.pp #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
142 changes: 48 additions & 94 deletions manifests/params.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
# PRIVATE CLASS: do not use directly
class mongodb::params inherits mongodb::globals {
$ensure = true
$dbpath = '/var/lib/mongodb'
$mongos_ensure = true
$bind_ip = pick($mongodb::globals::bind_ip, ['127.0.0.1'])
$ipv6 = undef
$service_manage = pick($mongodb::globals::mongod_service_manage, true)
$service_enable = pick($mongodb::globals::service_enable, true)
Expand Down Expand Up @@ -35,130 +37,82 @@

$config_data = undef

if $version {
$package_ensure = $version
$package_ensure_client = $version
$package_ensure_mongos = $version
} else {
$package_ensure = true
$package_ensure_client = true
$package_ensure_mongos = true
}

if $mongodb::globals::use_enterprise_repo {
$edition = 'enterprise'
} else {
$edition = 'org'
}

# Amazon Linux's OS Family is 'Linux', operating system 'Amazon'.
case $::osfamily {
'RedHat', 'Linux', 'Suse': {

if $manage_package {
$user = pick($mongodb::globals::user, 'mongod')
$group = pick($mongodb::globals::group, 'mongod')
if $version == undef {
$server_package_name = pick($mongodb::globals::server_package_name, 'mongodb-org-server')
$client_package_name = pick($mongodb::globals::client_package_name, 'mongodb-org-shell')
$mongos_package_name = pick($mongodb::globals::mongos_package_name, 'mongodb-org-mongos')
$package_ensure = true
$package_ensure_client = true
$package_ensure_mongos = true
} else {
$server_package_name = pick($mongodb::globals::server_package_name, 'mongodb-org-server')
$client_package_name = pick($mongodb::globals::client_package_name, 'mongodb-org-shell')
$mongos_package_name = pick($mongodb::globals::mongos_package_name, 'mongodb-org-mongos')
$package_ensure = $version
$package_ensure_client = $version
$package_ensure_mongos = $version
}
$service_name = pick($mongodb::globals::service_name, 'mongod')
$user = pick($mongodb::globals::user, 'mongod')
$group = pick($mongodb::globals::group, 'mongod')
$server_package_name = pick($mongodb::globals::server_package_name, "mongodb-${edition}-server")
$client_package_name = pick($mongodb::globals::client_package_name, "mongodb-${edition}-shell")
$mongos_package_name = pick($mongodb::globals::mongos_package_name, "mongodb-${edition}-mongos")
$mongos_service_name = pick($mongodb::globals::mongos_service_name, 'mongos')
$config = '/etc/mongod.conf'
$mongos_config = '/etc/mongodb-shard.conf'
$dbpath = '/var/lib/mongodb'
$logpath = '/var/log/mongodb/mongod.log'
$pidfilepath = '/var/run/mongodb/mongod.pid'
$bind_ip = pick($mongodb::globals::bind_ip, ['127.0.0.1'])
$mongos_pidfilepath = undef
$mongos_unixsocketprefix = undef
$mongos_logpath = undef
$mongos_fork = undef
} else {
# RedHat/CentOS doesn't come with a prepacked mongodb
# so we assume that you are using EPEL repository.
if $version == undef {
$package_ensure = true
$package_ensure_client = true
$package_ensure_mongos = true
} else {
$package_ensure = $version
$package_ensure_client = $version
$package_ensure_mongos = $version
}
$user = pick($mongodb::globals::user, 'mongodb')
$group = pick($mongodb::globals::group, 'mongodb')
$server_package_name = pick($mongodb::globals::server_package_name, 'mongodb-server')
$client_package_name = pick($mongodb::globals::client_package_name, 'mongodb')
$mongos_package_name = pick($mongodb::globals::mongos_package_name, 'mongodb-server')
$service_name = pick($mongodb::globals::service_name, 'mongod')
$dbpath = '/var/lib/mongodb'
$logpath = '/var/log/mongodb/mongodb.log'
$bind_ip = pick($mongodb::globals::bind_ip, ['127.0.0.1'])
$config = '/etc/mongod.conf'
$user = pick($mongodb::globals::user, 'mongodb')
$group = pick($mongodb::globals::group, 'mongodb')
$server_package_name = pick($mongodb::globals::server_package_name, 'mongodb-server')
$client_package_name = pick($mongodb::globals::client_package_name, 'mongodb')
$mongos_package_name = pick($mongodb::globals::mongos_package_name, 'mongodb-server')
$mongos_service_name = pick($mongodb::globals::mongos_service_name, 'mongos')
$mongos_config = '/etc/mongos.conf'
$pidfilepath = '/var/run/mongodb/mongod.pid'
$mongos_pidfilepath = '/var/run/mongodb/mongos.pid'
$mongos_unixsocketprefix = '/var/run/mongodb'
$mongos_logpath = '/var/log/mongodb/mongodb-shard.log'
$mongos_logpath = '/var/log/mongodb/mongos.log'
$mongos_fork = true
}
$fork = true
$journal = true

$service_name = pick($mongodb::globals::service_name, 'mongod')
$logpath = '/var/log/mongodb/mongod.log'
$pidfilepath = '/var/run/mongodb/mongod.pid'
$config = '/etc/mongod.conf'
$fork = true
$journal = true
}
'Debian': {
if $manage_package {
$user = pick($mongodb::globals::user, 'mongodb')
$group = pick($mongodb::globals::group, 'mongodb')
if $mongodb::globals::use_enterprise_repo {
$edition = 'enterprise'
} else {
$edition = 'org'
}
if ($version == undef) {
$server_package_name = pick($mongodb::globals::server_package_name, "mongodb-${edition}-server")
$client_package_name = pick($mongodb::globals::client_package_name, "mongodb-${edition}-shell")
$mongos_package_name = pick($mongodb::globals::mongos_package_name, "mongodb-${edition}-mongos")
$package_ensure = true
$package_ensure_client = true
$package_ensure_mongos = true
$service_name = pick($mongodb::globals::service_name, 'mongod')
$config = '/etc/mongod.conf'
} else {
$server_package_name = pick($mongodb::globals::server_package_name, "mongodb-${edition}-server")
$client_package_name = pick($mongodb::globals::client_package_name, "mongodb-${edition}-shell")
$mongos_package_name = pick($mongodb::globals::mongos_package_name, "mongodb-${edition}-mongos")
$package_ensure = $version
$package_ensure_client = $version
$package_ensure_mongos = $version
$service_name = pick($mongodb::globals::service_name, 'mongod')
$config = '/etc/mongod.conf'
}
$service_name = pick($mongodb::globals::service_name, 'mongod')
$server_package_name = pick($mongodb::globals::server_package_name, "mongodb-${edition}-server")
$client_package_name = pick($mongodb::globals::client_package_name, "mongodb-${edition}-shell")
$mongos_package_name = pick($mongodb::globals::mongos_package_name, "mongodb-${edition}-mongos")
$mongos_service_name = pick($mongodb::globals::mongos_service_name, 'mongos')
$mongos_config = '/etc/mongodb-shard.conf'
$dbpath = '/var/lib/mongodb'
$logpath = '/var/log/mongodb/mongodb.log'
$config = '/etc/mongod.conf'
$pidfilepath = pick($mongodb::globals::pidfilepath, '/var/run/mongod.pid')
$bind_ip = pick($mongodb::globals::bind_ip, ['127.0.0.1'])
} else {
if $version == undef {
$package_ensure = true
$package_ensure_client = true
$package_ensure_mongos = true
} else {
$package_ensure = $version
$package_ensure_client = $version
$package_ensure_mongos = $version
}
$user = pick($mongodb::globals::user, 'mongodb')
$group = pick($mongodb::globals::group, 'mongodb')
$server_package_name = pick($mongodb::globals::server_package_name, 'mongodb-server')
$client_package_name = $mongodb::globals::client_package_name
$client_package_name = pick($mongodb::globals::client_package_name, 'mongodb-clients')
$mongos_package_name = pick($mongodb::globals::mongos_package_name, 'mongodb-server')
$service_name = pick($mongodb::globals::service_name, 'mongodb')
$mongos_service_name = pick($mongodb::globals::mongos_service_name, 'mongos')
$config = '/etc/mongodb.conf'
$mongos_config = '/etc/mongodb-shard.conf'
$dbpath = '/var/lib/mongodb'
$logpath = '/var/log/mongodb/mongodb.log'
$bind_ip = pick($mongodb::globals::bind_ip, ['127.0.0.1'])
$pidfilepath = $mongodb::globals::pidfilepath
}
$user = pick($mongodb::globals::user, 'mongodb')
$group = pick($mongodb::globals::group, 'mongodb')
$logpath = '/var/log/mongodb/mongodb.log'
$mongos_config = '/etc/mongodb-shard.conf'
# avoid using fork because of the init scripts design
$fork = undef
$journal = undef
Expand All @@ -168,7 +122,7 @@
$mongos_fork = undef
}
default: {
fail("Osfamily ${::osfamily} and ${::operatingsystem} is not supported")
fail("Osfamily ${::osfamily} is not supported")
}
}
}
13 changes: 10 additions & 3 deletions spec/classes/server_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,21 @@
let(:facts) { facts }

let(:config_file) do
case facts[:os]['family']
when 'Debian'
if facts[:os]['family'] == 'Debian'
'/etc/mongodb.conf'
else
'/etc/mongod.conf'
end
end

let(:log_path) do
if facts[:os]['family'] == 'Debian'
'/var/log/mongodb/mongodb.log'
else
'/var/log/mongodb/mongod.log'
end
end

describe 'with defaults' do
it_behaves_like 'server classes'

Expand All @@ -40,7 +47,7 @@
with_content(%r{^storage\.dbPath: /var/lib/mongodb$}).
with_content(%r{^net\.bindIp: 127\.0\.0\.1$}).
with_content(%r{^systemLog\.logAppend: true$}).
with_content(%r{^systemLog\.path: /var/log/mongodb/mongodb.log$})
with_content(%r{^systemLog\.path: #{log_path}$})
end

if facts[:os]['family'] == 'Debian'
Expand Down
⚡