Add aptkey_options parameter to mongodb::repo class#524
Merged
bastelfreak merged 3 commits intovoxpupuli:masterfrom Jan 28, 2019
Merged
Add aptkey_options parameter to mongodb::repo class#524bastelfreak merged 3 commits intovoxpupuli:masterfrom
bastelfreak merged 3 commits intovoxpupuli:masterfrom
Conversation
Adding this parameter so we can pass proxy settings for example
bastelfreak
reviewed
Jan 16, 2019
bastelfreak
reviewed
Jan 28, 2019
| } | ||
|
|
||
| contain mongodb::repo::apt | ||
| contain ::mongodb::repo::apt |
Member
There was a problem hiding this comment.
please don't add the leading ::. This is a deprecated syntax, required for Puppet 3.
Member
|
The CI jobs are currently failing because of puppetlabs/beaker-puppet#102. We need to rerun them after the fix got merged and released. |
Member
|
To clarify, we don't support puppet 3, so the |
Contributor
Author
|
Ah, after a quick google I understand what you mean. I also have updated my local gem set and removed the |
Member
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Adding an
aptkey_optionsparameter so we can pass for example proxy settings to theapt::keyresource via hiera: