Fix a dependency cycle caused by Apt::Source from puppetlabs-apt 6.3.0

[thaiphv]

Pull Request (PR) description

Use the HTTP repositories of the Debian packages in an attempt to fix a dependency cycle caused by the Apt::Source class when it tries to install the apt-transport-https package if the repository locations are HTTPS.

This Pull Request (PR) fixes the following issues

Fixes #527

[alexjfisher]

I think the problem is actually with the resource collector finding more than anticipated.

puppet-mongodb/manifests/repo/apt.pp

Line 20 in 5133782

Apt::Source['mongodb']->Package<|tag == 'mongodb'|>

Puppet will automatically tag resources in this module with mongodb and I also think if apt is included from here, it’s resources might also get the mongodb tag.

[alexjfisher]

@thaiphv Thanks for reporting this and the PR. This looks like a workaround instead of a bug fix. I’d like to investigate the root cause before making this change.

[thaiphv]

@alexjfisher I agree that I was more of a workaround rather than a fix. I'll try out your idea and report it back.

[alexjfisher]

@thaiphv Would you be able to try the following out for me?

Could you change the tag parameter used from mongodb to eg. mongo_package?
I think the following 4 locations would need updating.

puppet-mongodb/manifests/client.pp

Line 17 in 568dc28

tag => 'mongodb',

puppet-mongodb/manifests/server/install.pp

Line 32 in eb21d8a

tag => 'mongodb',

puppet-mongodb/manifests/repo/yum.pp

Line 16 in 9c0ef87

Yumrepo['mongodb'] -> Package<|tag == 'mongodb'|>

puppet-mongodb/manifests/repo/apt.pp

Line 20 in 5133782

Apt::Source['mongodb']->Package<|tag == 'mongodb'|>

Thanks

[thaiphv]

@alexjfisher I can confirm that your suggested changes fixed the issue.

[alexjfisher]

@thaiphv Thanks!

[thaiphv]

@alexjfisher thanks for your comments