Only create database and user when mongodb_is_master

[JvGinkel]

Pull Request (PR) description

Only create database and user when running on a primary/master node. This way we have idempotent runs again on none primary servers.

Unfortunately the fact returns a string true so there is some ugliness with lint:ignore in the if statement.

This Pull Request (PR) fixes the following issues

Fixes #412

[ekohl]

Looks like this breaks tests and actually breaks idempotency in the acceptance tests. This is probably because the fact is not_installed before the first run meaning this breaks being able to provision in a single run.

[JvGinkel]

@ekohl good point, I changed the condition so the code will always be executed unless the value is false what should mean that we are on a non-master node.

What do you think?

[bastelfreak]

@JvGinkel can you take a look at the failing acceptance tests?

[bastelfreak]

hrm. those issues might come for a new rspec/rspec-puppet release. CC: @alexjfisher

[JvGinkel]

Hi @bastelfreak I just did a pdk bundle exec rake spec and I can't reproduce the errors so it's a bit hard to fix these.

[alexjfisher]

@JvGinkel You can't reproduce it this morning because rspec-puppet 2.7.7 was released a few hours ago and it fixed the issue. I've restarted your build and now it passes.

[ekohl]

I think this should be good to go.

[oniGino]

This always returns true on my systems, am I missing something? Running puppet 5.5.20 with PE 2018.1 and module 3.1.0

[igalic]

@oniGino does your system have more than one node?

[oniGino]

@oniGino does your system have more than one node?

Yes 3 nodes,