fix(is_master-fact): use --ssl if --sslPEMKeyFile or --sslCAFile is s…#573
Merged
bastelfreak merged 2 commits intovoxpupuli:masterfrom Feb 10, 2020
Merged
Conversation
buchstabensalat
force-pushed
the
fix_facter_allowSSL
branch
2 times, most recently
from
b11b52d to
4cf3cdf
Compare
Member
|
Thanks for the PR @buchstabensalat. Can you take a look at the used email address in the commit? It isn't associated with your github account. |
buchstabensalat
force-pushed
the
fix_facter_allowSSL
branch
from
4cf3cdf to
a4d6a65
Compare
…istening to 0.0.0.0 or ::0 because localhost ist not part of any certificate if ssl is enabled
Contributor
Author
|
Hi, i have changed the mailaddress of the commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
When using SSL in any other mode than requireSSL and you have specified a server or ca-certificate the mongodb_is_master fact will fail.
It will generate a shell command like "mongo --quiet --sslPEMKeyFile $file" which results in an
"Failed global initialization: BadValue ssl is required when ssl.PEMKeyFile is specified".
This pull-Request ensures that "--ssl" is also set when setting --sslPEMKeyFile or --sslCAFile.