Skip to content

Add support for Suse Linux#624

Merged
bastelfreak merged 31 commits intovoxpupuli:masterfrom
pixelpark:fix-upstream
Oct 28, 2021
Merged

Add support for Suse Linux#624
bastelfreak merged 31 commits intovoxpupuli:masterfrom
pixelpark:fix-upstream

Conversation

@fbrehm
Copy link
Copy Markdown
Contributor

@fbrehm fbrehm commented Sep 7, 2021

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@kenyon kenyon added needs-rebase enhancement New feature or request labels Sep 7, 2021
Copy link
Copy Markdown
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add Suse to metadata.json?

I see unrelated changes, maybe due to the merge commits?

You can probably fix this by rebasing and squashing your commits:

From your working directory:

git fetch origin            # Download the latest code we have here
git rebase origin/master    # Move your commits on top of the main branch
git rebase -i origin/master # Interactively rewrite history

This will bring your editor. Keep the first line unchanged, and replace pick with squash for all subsequent lines. Save and quit, your editor will allow you to combine the commit messages in a single commit message.

Then push your updated branch to update the Pull-Request:

git push -f            # Send the changes (-f is required because we re-wrote history)

Comment thread manifests/repo.pp Outdated
Comment thread metadata.json Outdated
@fbrehm fbrehm requested a review from smortex September 20, 2021 15:21
Comment thread manifests/mongos/install.pp
Comment thread manifests/mongos/params.pp Outdated
Comment thread manifests/repo.pp Outdated
Comment thread manifests/repo/zypper.pp
Comment thread manifests/repo/zypper.pp
Comment thread metadata.json Outdated
@bastelfreak
Copy link
Copy Markdown
Member

Hi @fbrehm , can you take a look at the above comments?

fbrehm and others added 5 commits October 28, 2021 11:17
@bastelfreak bastelfreak merged commit 2e6001a into voxpupuli:master Oct 28, 2021
@bastelfreak bastelfreak changed the title Adding support for Suse Linux Add support for Suse Linux Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants