Add support for Suse Linux#624
Merged
bastelfreak merged 31 commits intovoxpupuli:masterfrom Oct 28, 2021
Merged
Conversation
Version 4.0.0
smortex
requested changes
Sep 7, 2021
Member
smortex
left a comment
There was a problem hiding this comment.
Can you add Suse to metadata.json?
I see unrelated changes, maybe due to the merge commits?
You can probably fix this by rebasing and squashing your commits:
From your working directory:
git fetch origin # Download the latest code we have here
git rebase origin/master # Move your commits on top of the main branch
git rebase -i origin/master # Interactively rewrite history
This will bring your editor. Keep the first line unchanged, and replace pick with squash for all subsequent lines. Save and quit, your editor will allow you to combine the commit messages in a single commit message.
Then push your updated branch to update the Pull-Request:
git push -f # Send the changes (-f is required because we re-wrote history)
bastelfreak
reviewed
Sep 21, 2021
bastelfreak
reviewed
Sep 21, 2021
bastelfreak
reviewed
Sep 21, 2021
bastelfreak
reviewed
Sep 21, 2021
bastelfreak
reviewed
Sep 21, 2021
bastelfreak
reviewed
Sep 21, 2021
Member
|
Hi @fbrehm , can you take a look at the above comments? |
…eclaring it for private.
Update metadata.json - lower version boundary Co-authored-by: Tim Meusel <tim@bastelfreak.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues