mongodb_user ignores database parameter when removing a user#644
Merged
root-expert merged 1 commit intovoxpupuli:masterfrom Sep 18, 2022
Merged
mongodb_user ignores database parameter when removing a user#644root-expert merged 1 commit intovoxpupuli:masterfrom
database parameter when removing a user#644root-expert merged 1 commit intovoxpupuli:masterfrom
Conversation
Contributor
Author
|
I have a feeling, this patch needs to be applied to get tests running. Should this be in this PR or a separate one? diff --git a/.fixtures.yml b/.fixtures.yml
index 9937c6d..97dc093 100644
--- a/.fixtures.yml
+++ b/.fixtures.yml
@@ -1,7 +1,7 @@
fixtures:
repositories:
- "stdlib": "git://github.com/puppetlabs/puppetlabs-stdlib.git"
- "apt": "git://github.com/puppetlabs/puppetlabs-apt.git"
+ "stdlib": "https://github.com/puppetlabs/puppetlabs-stdlib.git"
+ "apt": "https://github.com/puppetlabs/puppetlabs-apt.git"
"systemd": "https://github.com/voxpupuli/puppet-systemd.git"
"zypprepo": "https://github.com/voxpupuli/puppet-zypprepo.git"
yumrepo_core: |
Member
|
I just merged #643 which include it. Let's re-trigger a build |
Member
|
Hum, one day I will understand what GitHub does with the repo before running CI. I though it would merge the branch and the main branch but it seems not to… Can you please rebase your changes on top of the main branch? From your working directory: Thanks! |
04599d4 to
57926cd
Compare
Contributor
Author
|
Different failures, I'll take a look at those now. |
57926cd to
942089d
Compare
smortex
approved these changes
Jul 8, 2022
Member
smortex
left a comment
There was a problem hiding this comment.
LGTM. Not a user of this module so I will let another Vox member approve and merge this. Thanks!
poloz-lab
approved these changes
Sep 8, 2022
root-expert
approved these changes
Sep 18, 2022
database parameter when removing a user
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Currently setting
ensure => absentfor a user doesn't work for users created in other databases thanadminThis Pull Request (PR) fixes the following issues
This PR fixes this by passing the database value to
mongo_eval