Skip to content

Move default version to repo.pp #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikhaildudzin wants to merge 1 commit into from
Closed

Move default version to repo.pp #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/globals.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
Optional[String[1]] $version = undef,
Optional[String[1]] $client_version = undef,
Boolean $manage_package_repo = true,
String[1] $repo_version = '5.0',
Optional[String[1]] $repo_version = undef,
Boolean $use_enterprise_repo = false,
Optional[String] $repo_location = undef,
Optional[String] $keyring_location = undef,
Expand Down
2 changes: 1 addition & 1 deletion manifests/repo.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
Optional[String[1]] $proxy_password = undef,
) {
if $version == undef and $repo_location == undef {
fail('`version` or `repo_location` is required')
$version = '5.0'
}
if $version != undef and $repo_location != undef {
Copy link
Copy Markdown
Contributor

@h-haaks h-haaks Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikhaildudzin please have a look at #779. I have removed this test so that $version is just ignored when $repo_location is set.

Copy link
Copy Markdown
Author

@mikhaildudzin mikhaildudzin Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, going to close this PR
Thanks for collaboration

fail('`version` is not supported with `repo_location`')
Expand Down
⚡