Skip to content

increase lower bounds for stdlib, vcsrepo#327

Merged
kenyon merged 1 commit intovoxpupuli:masterfrom
kenyon:bump-deps
Aug 3, 2021
Merged

increase lower bounds for stdlib, vcsrepo#327
kenyon merged 1 commit intovoxpupuli:masterfrom
kenyon:bump-deps

Conversation

@kenyon
Copy link
Copy Markdown
Member

@kenyon kenyon commented Apr 9, 2021

Closes #326.

@kenyon kenyon added the backwards-incompatible This change will lead to a major version bump for the next release label Apr 9, 2021
@t-valette
Copy link
Copy Markdown

Hello @kenyon,

I'm not sure puppet/puppetboard is compatible with puppet/python >= 6 as we still find virtualenv and manage_virtualenv_package in the init file.
If you look at the changelog of puppet/python, we can see that these parameters are no longer present:

  • Drop python::virtualenv defined resource from changelog
  • no more reference to virtual in the init file 6.0.0+
  • explanation on why virtualenv is now deprecated in the PR

Also, I tested with your PR and that's what I'm getting (with mod 'puppet/python', :latest in our Puppetfile) :

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Class[Python]:
  has no parameter named 'virtualenv'
  has no parameter named 'manage_virtualenv_package' (file: /.../production/modules/puppetboard/manifests/init.pp, line: 188, column: 5) on node puppet...

Here, I see two solutions for that (I'm not a puppet expert, maybe I wrong but I try to add some ideas):

  • dropping virtualenv parameters for systems having puppet/python >= 6.0.0
  • use python::pyvenv described here which is already present in puppet/python >= 4.1.0

@kenyon
Copy link
Copy Markdown
Member Author

kenyon commented Apr 12, 2021

Indeed, I did not look for such incompatibilities. I figured we could find and fix those in other pull requests. So if you could submit a PR that would be great. 👍

Comment thread metadata.json Outdated
@kenyon kenyon force-pushed the bump-deps branch 2 times, most recently from be8bebb to 791732d Compare April 27, 2021 03:44
@kenyon
Copy link
Copy Markdown
Member Author

kenyon commented Apr 27, 2021

Don't know why travis times out trying to download the puppetdb module. Maybe it needs puppetlabs/puppetlabs-puppetdb#327

Copy link
Copy Markdown
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After review of the differences which where part of #317, it seems two lower bounds where not included and if applicable, we can update this PR to fix this.

Comment thread metadata.json
Comment thread metadata.json Outdated
@kenyon kenyon changed the title drop puppet5 support; bump puppet, stdlib, python, vcsrepo deps increase lower bounds for stdlib, vcsrepo Aug 3, 2021
@kenyon kenyon merged commit 021bfd9 into voxpupuli:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards-incompatible This change will lead to a major version bump for the next release tests-fail

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Puppet-python version dependency update

5 participants