Conversation
|
@LinusBorg Could you review this PR please ? :) |
jeffposnick
left a comment
There was a problem hiding this comment.
I believe this is unrelated to the service worker-controlled experience, since there's no service worker generated in the dev environment, and I don't see anything that's changed in the npm run build output.
Therefore, I'm happy to get this implemented to match what's being done upstream in the webpack template.
I'll give @LinusBorg a little more time to comment in case there were more plans for changes upstream, but otherwise, this should be good.
|
Any news about this PR? It's been a while since vuejs-templates/webpack#975 was merged. It's great to have this pwa template in sync with progress made in the base template (webpack). |
|
Hey totally forgot about this, sorry. There were some hickups we had after we merged the initial PR (vuejs-templates/webpack#975), I'll share those wit you tomorrow when I find a minute to write it down properly. As all of those additional changes were about the webpack config, you can also see them when looking at the current version of |
|
Hello! What is the status of this PR? I found myself having to turn HTTPS on for development in my app (Facebook login now requires it) and this looks like what I need to enable it, but @LinusBorg's comment makes me think that there are issues with this still. Thanks! |
Applied vuejs-templates/webpack#975 + vuejs-templates/webpack@deb97b1