Skip to content
This repository was archived by the owner on Dec 26, 2018. It is now read-only.

Fixes #138 Fixes #162 Optionally apply config#179

Open
thomas07vt wants to merge 1 commit intovuejs:masterfrom
thomas07vt:issues/138-browserify-transformations-fix
Open

Fixes #138 Fixes #162 Optionally apply config#179
thomas07vt wants to merge 1 commit intovuejs:masterfrom
thomas07vt:issues/138-browserify-transformations-fix

Conversation

@thomas07vt
Copy link
Copy Markdown

options._flags is not always set when using browserify transformations

  • version affected: "vueify": "^9.4.0"

Example of failure in gulp file

// gulpfile.js
gulp.task('all', function() {
    process.env.NODE_ENV = 'production';
    return browserify('./source/js/all.js')
        .transform(babelify.configure({ presets: ["es2015"]}))
        .transform(vueify)
        .bundle()
        .pipe(source('./js/all.js'))
        .pipe(buffer())
        .pipe(rev())
        .pipe(gulp.dest(pub))
        .pipe(rev.manifest('./build/rev-manifest.json', {
          base: '',
          merge: true
        }))
        .pipe(gulp.dest('.'));
});
$ gulp all

[19:15:56] Using gulpfile ~/gulpfile.js
[19:15:56] Starting 'all'...
code/node_modules/vueify/index.js:12
    sourceMap: options._flags.debug
                             ^

TypeError: Cannot read property 'debug' of undefined
    at vueify (code/node_modules/vueify/index.js:12:30)

options._flags is not always set when using browserify transformations

- version affected: "vueify": "^9.4.0"

Example of failure in gulp file

```javascript
// package.json
gulp.task('all', function() {
    process.env.NODE_ENV = 'production';
    return browserify('./source/js/all.js')
        .transform(babelify.configure({ presets: ["es2015"]}))
        .transform(vueify)
        .bundle()
        .pipe(source('./js/all.js'))
        .pipe(buffer())
        .pipe(rev())
        .pipe(gulp.dest(pub))
        .pipe(rev.manifest('./build/rev-manifest.json', {
          base: '',
          merge: true
        }))
        .pipe(gulp.dest('.'));
});

```

```bash
$ gulp all

[19:15:56] Using gulpfile ~/gulpfile.js
[19:15:56] Starting 'all'...
code/node_modules/vueify/index.js:12
    sourceMap: options._flags.debug
                             ^

TypeError: Cannot read property 'debug' of undefined
    at vueify (code/node_modules/vueify/index.js:12:30)

```
@thomas07vt
Copy link
Copy Markdown
Author

I don't actually know if this is the "correct" fix for this issue since I am still working on getting my first Vue app running, but it is a fix :)

@paul-maxime
Copy link
Copy Markdown

Looks like a duplicate of #172, but I approve this fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants