Memory increase: Update from 4.0.2 to 4.1.0

[fallemand]

Version

4.1.0

Describe the bug

After upgrading from Vuex 4.0.2 to 4.1.0, our apps started skyrocketing in memory consumption until running out of memory.

The apps recovered just after the rollback was deployed, and we tried two times to be sure.

Reproduction

• SSR Vue 3 app.
• Vuex 4.1.0

Expected behavior

Memory levels should remain the same.

Additional context

No response

Validations

• Follow our Code of Conduct
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

[zcrumbo]

For what it's worth, I've also seen a memory leak for an SSR'd Vue app after moving from 4.0.2 to 4.1. Reverting solved the issue.
The heap dump indicated the store was getting persisted in memory for every page render, leading to a very fast OOM crash on the deployed container.

[zcrumbo]

It seems like this change is what is responsible - the closure seems to be retained on the SSR process

vuex/src/store-util.js

Lines 40 to 58 in d562224

	const computedCache = {}
	// create a new effect scope and create computed object inside it to avoid
	// getters (computed) getting destroyed on component unmount.
	const scope = effectScope(true)
	scope.run(() => {
	forEachValue(wrappedGetters, (fn, key) => {
	// use computed to leverage its lazy-caching mechanism
	// direct inline function use will lead to closure preserving oldState.
	// using partial to return function with only arguments preserved in closure environment.
	computedObj[key] = partial(fn, store)
	computedCache[key] = computed(() => computedObj[key]())
	Object.defineProperty(store.getters, key, {
	get: () => computedCache[key].value,
	enumerable: true // for local getters
	})
	})
	})