Closed
Conversation
Fix inverted condition in TabsPanel that prevented proper ticket lookup by value. The condition checked for empty results (=== 0) when it should check for matches (> 0), causing panels to receive incorrect IDs and breaking aria-controls/aria-labelledby relationships with their corresponding tabs. Fixes tests: - "should have correct ARIA attributes" - "should match aria-controls and aria-labelledby" Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…' into claude/analyze-vuetify-progress-0FdqU
- Add TabsIndicator component for visual active state - Refactor focus management to use element refs instead of DOM queries - Add TabsTicket type extending StepTicket with element ref - Add TabsState type for active/inactive styling - Add TabsTabContext for child component communication - Add JSDoc examples to compound object exports - Add ARIA props (ariaLabelledby) to TabsList - Add forceMount prop to TabsPanel and TabsIndicator - Create documentation page with examples
- Rename TabsTab.vue to TabsItem.vue - Rename TabsTabContext to TabsItemContext - Rename useTabsTab/provideTabsTab to useTabsItem/provideTabsItem - Update TabsIndicator to use TabsItem context - Update default namespace from v0:tabs:tab to v0:tabs:item - Update all tests and documentation examples - Rename tabNamespace prop to itemNamespace
|
commit: |
johnleider
changed the base branch from
master
to
haviles04/feat-new-tab-component
johnleider
changed the base branch from
haviles04/feat-new-tab-component
to
master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.