Add opcodes and opcodes_runtime flags to compiler#1255
Merged
Conversation
fubuloubu
reviewed
Feb 19, 2019
fubuloubu
left a comment
Contributor
There was a problem hiding this comment.
It would be nice to have a short test to show off how this works. (I'd love for it to be a doctest, and actually use them)
jacqueswww
approved these changes
Feb 19, 2019
jacqueswww
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just fix the linting errors ;)
Contributor
|
@fubuloubu doc tests are great for a quick test suite, but in general I think it just adds too much clutter on a code base - especially since we have a very extensive test suite already. |
fubuloubu
approved these changes
Feb 19, 2019
Contributor
|
Doctests are nice because they keep the docs up to date |
Contributor
Author
oops! |
|
What's the difference between |
Contributor
Author
If you are familiar with
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
opcodesandopcodes_runtimeflags to the compilerHow I did it
PUSH,SWAPandDUPopcodes tovyper/opcodes.pyget_opcodestovyper/compiler.pyopcodesandopcodes_runtimetooutput_formats_mapinvyper/compiler.pybin/vyperHow to verify it
vyper -f opcodes examples/crowdfund.vyvyper -f opcodes_runtime examples/crowdfund.vyDescription for the changelog
opcodesandopcodes_runtimeflags to the compilerCute Animal Picture