Array copy optimization#1487
Merged
jacqueswww merged 1 commit intoJun 25, 2019
Merged
Conversation
Contributor
|
@charles-cooper I am not sure the description matches the code? |
17723a6 to
c8cea1b
Compare
Member
Author
|
@jacqueswww I force pushed so the diff is cleaner now. The array bounds check is elided in the make_setter loop now, so instead of for (i = 0; i < len; i++) {
dst[uclamplt(i, len)] = src[uclamplt(i, len)]
}it is now effectively for (i = 0; i < len; i++) {
dst[i] = src[i]
} |
jacqueswww
approved these changes
Jun 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Optimize compiler-generated array copies. Depends on #1479 because of a conflict
How I did it
Remove bounds checks for when a loop is compiler-generated.
How to verify it
Check before/after IR for this contract
Description for the changelog
Optimize compiler-generated array copies
Cute Animal Picture