Basic type conversions from address type#1524
Merged
jacqueswww merged 9 commits intoJul 16, 2019
Merged
Conversation
jakerockland
changed the title
address type
jacqueswww
suggested changes
Jul 15, 2019
jacqueswww
left a comment
jacqueswww
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just a minor note.
| [ | ||
| 'signextend', | ||
| 15, | ||
| ['and', in_arg, 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF], |
Contributor
There was a problem hiding this comment.
I think using SizeLimits here would be cleaner?
Contributor
There was a problem hiding this comment.
SizeLimits.ADDRSIZE specifically :)
Contributor
Author
There was a problem hiding this comment.
@jacqueswww ah good call! 😅 I had overlooked that that constant existed — will make this change tonight.
Contributor
Author
|
@jacqueswww fixed! |
jacqueswww
approved these changes
Jul 16, 2019
|
Is uint256 conversion implemented here? I don’t see it; only decimal, int128 and bool. Also, I don’t see these changes in the docs |
Contributor
|
I believe it is implemented, yes. Good catch, that should definitely be documented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Implements missing conversions from
addressto other basic types, as specified in #1093 — note conversion fromaddresstobytestype has yet to be implemented, but was holding off on this for this specific PR as there are also a handful of other conversions tobytestype that need to be implemented still and feel that could just be its own PR.How I did it
Updated
convert.pyto support new conversions.How to verify it
Run the tests
make testDescription for the changelog
Add missing conversions from
addresstype to other basic typesCute Animal Picture