AST end offsets and compressed source map#1580
Merged
fubuloubu merged 12 commits intoAug 24, 2019
Merged
Conversation
Contributor
|
@iamdefinitelyahuman I think the CLI switch is missing? |
Contributor
Author
|
@jacqueswww For now I've just included it as part of the output for If you'd like I can add another flag, |
Contributor
|
I reckon that's fine for now, especially because of #1520 👍 |
fubuloubu
approved these changes
Aug 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
pc_pos_mapHow I did it
asttokenslibraryend_linenoandend_col_offsetattributes to the final Vyper AST. (Attributes with these names are included in the standard ast library as of Python 3.8)LLLnodeobjects, and add their values topc_pos_mapas returned byvyper.compile_lll.assembly_to_evmpc_jump_maptoassembly_to_evmoutput, in the format{'program counter': [io-]}-iindicates a jump instruction going into a private function,ocoming out of a private function,-is an internal instruction such as a for loop or if / else statement.vyper.compiler.compress_source_map: given source code,pc_pos_mapandpc_jump_map, generates a compressed source map in the same format used bysolcvyper.compiler.expand_source_map: given a compressed source map string, expands it into a list of 4 item lists as[start, length, contract_id, jump]pc_jump_mapandpc_pos_map_compressedto compiler output given byvyper.compiler.get_source_mapHow to verify it
Run the tests. I have added several new test cases around the jump map and compressed source map.
Description for the changelog
Cute Animal Picture