Skip to content

Fixed 1636 unary negation bug#1638

Merged
fubuloubu merged 5 commits into
vyperlang:masterfrom
fubuloubu:1636-usub-bug
Oct 18, 2019
Merged

Fixed 1636 unary negation bug#1638
fubuloubu merged 5 commits into
vyperlang:masterfrom
fubuloubu:1636-usub-bug

Conversation

@fubuloubu

Copy link
Copy Markdown
Contributor

What I did

Fixed: #1636

How I did it

  • Reject Unary negation on unsigned integers
  • Clamped that unary negation must be strictly greater than minimum value for signed integer

Description for the changelog

Fixed unary negation bug

Cute Animal Picture

slow morning

@fubuloubu fubuloubu changed the title 1636 usub bug Fixed 1636 unary negation bug Oct 17, 2019
Comment thread tests/parser/functions/test_unary.py
Comment thread vyper/parser/expr.py Outdated

@charles-cooper charles-cooper left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overflow checking for unary operators

2 participants