Fix off-by-one in list type checking#1673
Merged
Merged
Conversation
jacqueswww
approved these changes
Nov 1, 2019
fubuloubu
reviewed
Nov 1, 2019
fubuloubu
left a comment
fubuloubu
left a comment
Contributor
There was a problem hiding this comment.
It would be great if this off by one error had a test case
fubuloubu
approved these changes
Nov 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix off-by-one in list type checking
How I did it
The loop wanted to check if there were any elements in the output list yet, but the check should have been
>= 1instead of> 1How to verify it
Description for the changelog
Fix off-by-one in check for homogeneous list element types.
Cute Animal Picture