Add zeroing function for arrays by charles-cooper · Pull Request #1676 · vyperlang/vyper

charles-cooper · 2019-11-01T09:43:20Z

What I did

Fix initializing empty arrays #1675 by introducing syntax for initializing new arrays with zero

How I did it

Get rid of NullType from codebase. Zeroing operations are now from the None sentinel value alone.
Factor mzero into a function

How to verify it

See tests

Description for the changelog

Introduce syntax for initializing new arrays with zero
Check array assignment is always between arrays of same length

Cute Animal Picture

fubuloubu · 2019-11-12T14:09:03Z

Edit: moved discussion back to issue

fubuloubu · 2019-11-14T18:44:35Z

can you rebase on master?

charles-cooper · 2019-11-14T18:47:00Z

can you rebase on master?

@fubuloubu is this because you force pushed to master 😂 ? in the future can we protect master from all pushes except from PRs?

fubuloubu · 2019-11-14T19:10:54Z

Maybe, that wasn't the commit that was lost though

charles-cooper · 2019-11-28T17:44:20Z

some work on the gas estimator is still needed

fubuloubu · 2019-12-06T16:55:12Z

Rebase on master to get updated CI

charles-cooper · 2019-12-06T22:48:49Z

some work on the gas estimator is still needed

I fixed it.

fubuloubu

LGTM

Still want to discuss the naming though. I dislike clear

fubuloubu · 2019-12-09T16:31:38Z

Meeting notes: Change to empty, leave current use of clear for now, but could be deprecated in the future.

jacqueswww

Can we get this merged (see above renaming, then ✔️ ) ? 🚀

michwill · 2020-01-31T20:48:49Z

What would be pythonic is something like a: uint256[10] = [0 for _ in range(10)], or even a: uint256[10] = [0] * 10

fubuloubu · 2020-01-31T20:52:47Z

@michwill the later would be the better choice, but we had a very long conversation about this and enabling the Pythonic list comprehension syntax is a rabbit hole, plus empty is more broadly useful.

lgtm-com · 2020-04-07T18:22:55Z

This pull request introduces 3 alerts when merging 47d07b8 into e27fd81 - view on LGTM.com

new alerts:

2 for Syntax error
1 for Unused import

lgtm-com · 2020-04-07T19:04:51Z

This pull request introduces 2 alerts when merging 8fdb472 into e27fd81 - view on LGTM.com

new alerts:

1 for Unused import
1 for Unreachable code

this handles the transformation from None to 0 for base types.

lgtm-com · 2020-04-07T20:08:07Z

This pull request introduces 3 alerts when merging dbb078a into e27fd81 - view on LGTM.com

new alerts:

2 for Unused import
1 for Unreachable code

codecov-io · 2020-04-07T20:31:43Z

Codecov Report

Merging #1676 into master will increase coverage by 0.12%.
The diff coverage is 85.00%.

@@            Coverage Diff             @@
##           master    #1676      +/-   ##
==========================================
+ Coverage   86.55%   86.67%   +0.12%     
==========================================
  Files          55       55              
  Lines        6343     6335       -8     
  Branches     1630     1629       -1     
==========================================
+ Hits         5490     5491       +1     
+ Misses        551      543       -8     
+ Partials      302      301       -1

Impacted Files	Coverage Δ
vyper/ast/nodes.py	`85.50% <ø> (+0.85%)`	⬆️
vyper/types/types.py	`88.51% <ø> (-0.17%)`	⬇️
vyper/parser/expr.py	`87.96% <50.00%> (-0.40%)`	⬇️
vyper/functions/functions.py	`95.44% <60.00%> (-0.23%)`	⬇️
vyper/parser/stmt.py	`92.45% <83.33%> (+0.18%)`	⬆️
vyper/parser/parser_utils.py	`87.43% <88.88%> (+1.64%)`	⬆️
vyper/parser/lll_node.py	`82.93% <100.00%> (ø)`
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e27fd81...865bcfd. Read the comment docs.

lgtm-com · 2020-04-07T20:40:11Z

This pull request introduces 1 alert when merging c9f935d into e27fd81 - view on LGTM.com

new alerts:

1 for Unused import

fubuloubu · 2020-04-07T21:21:09Z

-    )
+def empty(expr, context):
+    if len(expr.args) != 1:
+        raise ParserException('function expects two parameters.', expr)


Suggested change

raise ParserException('function expects two parameters.', expr)

raise ArgumentException('function expects one parameter.', expr)

I think ArgumentException is the most fitting exception to raise here. ParserException implies that the code can't be parsed. It also doesn't support annotation.

charles-cooper · 2020-04-08T00:59:21Z

I'm OK merging this with the caveat that users might have some trouble passing empty to and from functions. The compiler will probably just complain. Should be fixed once arg packing / unpacking is refactored.

iamdefinitelyahuman · 2020-04-08T09:12:03Z

-    )
+def empty(expr, context):
+    if len(expr.args) != 1:
+        raise ParserException('function expects two parameters.', expr)


I think ArgumentException is the most fitting exception to raise here. ParserException implies that the code can't be parsed. It also doesn't support annotation.

they're taken care of

or2008 · 2020-06-25T10:56:55Z

hello, how can I use empty to mimic solidity's new bytes(0)?

looks like empty(bytes[1024]) causes this exception:

vyper.exceptions.CompilerPanic: Unsupported location: None Please create an issue.vyper.exceptions.CompilerPanic: Unsupported location: None Please create an issue.

fubuloubu · 2020-06-25T12:43:55Z

@or2008 can you do us a favor and create a new issue with the source code that is giving you the problem? Thanks!

or2008 · 2020-07-17T14:11:25Z

sure, opened #2112

jacqueswww reviewed Nov 1, 2019

View reviewed changes

Comment thread vyper/parser/parser_utils.py

fubuloubu added the work in progress Work on this PR or issue is not yet complete but reviewers are free to add their input for guidance. label Nov 6, 2019

charles-cooper force-pushed the uninitialized_array branch from 6cf59b9 to 5a09d40 Compare November 12, 2019 12:51

charles-cooper changed the title ~~WIP allow arrays to be syntactically uninitialized~~ Add zeroing function for arrays Nov 12, 2019

charles-cooper requested review from fubuloubu and jacqueswww November 12, 2019 13:45

charles-cooper removed the work in progress Work on this PR or issue is not yet complete but reviewers are free to add their input for guidance. label Nov 12, 2019

charles-cooper force-pushed the uninitialized_array branch from e159288 to fef941a Compare November 12, 2019 13:58

fubuloubu force-pushed the master branch from 06fa370 to 78b4d9c Compare November 13, 2019 01:18

charles-cooper mentioned this pull request Nov 14, 2019

Fix struct assignment order #1728

Merged

charles-cooper force-pushed the uninitialized_array branch from 5dc0878 to 49ab516 Compare November 15, 2019 14:31

fubuloubu mentioned this pull request Nov 25, 2019

Meeting 9th December 2019 #1734

Closed

5 tasks

fubuloubu reviewed Nov 27, 2019

View reviewed changes

Comment thread vyper/parser/lll_node.py Outdated

charles-cooper force-pushed the uninitialized_array branch from 49ab516 to e460637 Compare November 28, 2019 17:25

charles-cooper added the work in progress Work on this PR or issue is not yet complete but reviewers are free to add their input for guidance. label Nov 28, 2019

charles-cooper force-pushed the uninitialized_array branch from 132cb83 to a70257f Compare November 28, 2019 17:37

charles-cooper force-pushed the uninitialized_array branch 2 times, most recently from ee5f52a to 37c8cbc Compare December 6, 2019 22:45

fubuloubu approved these changes Dec 7, 2019

View reviewed changes

jacqueswww approved these changes Jan 27, 2020

View reviewed changes

charles-cooper added 2 commits April 7, 2020 20:06

fix: catch stray merge errors

4a6fd40

fix: put None branch back in base_type_conversion

e2d6a96

this handles the transformation from None to 0 for base types.

charles-cooper added 4 commits April 7, 2020 20:25

refactor: make base_type_conversion readable

b93a538

fix: fix typechecker for list assign None

a8ea89f

fix: remove old struct checker for None

6221a8e

fix: rhs type for tuple assign

c9f935d

charles-cooper force-pushed the uninitialized_array branch from dbb078a to c9f935d Compare April 7, 2020 20:26

fubuloubu approved these changes Apr 7, 2020

View reviewed changes

fix lint

d02a77c

fubuloubu removed the work in progress Work on this PR or issue is not yet complete but reviewers are free to add their input for guidance. label Apr 8, 2020

iamdefinitelyahuman previously requested changes Apr 8, 2020

View reviewed changes

minor fixes from review

cd3118a

fubuloubu reviewed Apr 8, 2020

View reviewed changes

Comment thread vyper/functions/functions.py

fubuloubu reviewed Apr 8, 2020

View reviewed changes

Comment thread vyper/functions/functions.py Outdated

charles-cooper added 3 commits April 8, 2020 17:26

fix type check when rhs is empty list/struct

0c934c4

add xfail tests for empty param/return

7cf2766

replace parser exc with argument exc

865bcfd

fubuloubu approved these changes Apr 8, 2020

View reviewed changes

fubuloubu requested a review from iamdefinitelyahuman April 8, 2020 18:40

fubuloubu merged commit 4514fa5 into vyperlang:master Apr 8, 2020

	raise ParserException('function expects two parameters.', expr)
	raise ArgumentException('function expects one parameter.', expr)

Uh oh!

Conversation

charles-cooper commented Nov 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

How I did it

How to verify it

Description for the changelog

Cute Animal Picture

Uh oh!

Uh oh!

fubuloubu commented Nov 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fubuloubu commented Nov 14, 2019

Uh oh!

charles-cooper commented Nov 14, 2019

Uh oh!

fubuloubu commented Nov 14, 2019

Uh oh!

Uh oh!

charles-cooper commented Nov 28, 2019

Uh oh!

fubuloubu commented Dec 6, 2019

Uh oh!

charles-cooper commented Dec 6, 2019

Uh oh!

fubuloubu left a comment

Choose a reason for hiding this comment

Uh oh!

fubuloubu commented Dec 9, 2019

Uh oh!

jacqueswww left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michwill commented Jan 31, 2020

Uh oh!

fubuloubu commented Jan 31, 2020

Uh oh!

lgtm-com Bot commented Apr 7, 2020

Uh oh!

lgtm-com Bot commented Apr 7, 2020

Uh oh!

lgtm-com Bot commented Apr 7, 2020

Uh oh!

codecov-io commented Apr 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lgtm-com Bot commented Apr 7, 2020

Uh oh!

fubuloubu Apr 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iamdefinitelyahuman Apr 8, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

charles-cooper commented Apr 8, 2020

Uh oh!

iamdefinitelyahuman Apr 8, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

or2008 commented Jun 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fubuloubu commented Jun 25, 2020

Uh oh!

or2008 commented Jul 17, 2020

Uh oh!

Reviewers

Assignees

Labels

charles-cooper commented Nov 1, 2019 •

edited

Loading

fubuloubu commented Nov 12, 2019 •

edited

Loading

jacqueswww left a comment •

edited

Loading

codecov-io commented Apr 7, 2020 •

edited

Loading

fubuloubu Apr 7, 2020 •

edited

Loading

or2008 commented Jun 25, 2020 •

edited

Loading