Make scientific notation an invalid literal declaration#1681
Merged
Conversation
fubuloubu
added
the
work in progress
fubuloubu
changed the title
fubuloubu
force-pushed
the
fubuloubu/1680-scientific-notation
branch
from
855dce2 to
fd9f3d0
Compare
fubuloubu
removed
the
work in progress
fubuloubu
changed the title
charles-cooper
approved these changes
Nov 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #1680
What I did
Raise
InvalidLiteralExceptionwhen scientific notation is used for a literal value (either for a constant, or in a method)How I did it
WIP
How to verify it
Well, tests fail...
Description for the changelog
Added additional verification of literals to ensure scientific notation was not used (as Python interprets as a float)
Cute Animal Picture