Add branch coverage reporting#1743
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1743 +/- ##
=========================================
- Coverage 91.9% 87% -4.91%
=========================================
Files 48 48
Lines 5647 5647
Branches 0 1514 +1514
=========================================
- Hits 5190 4913 -277
Misses 457 457
- Partials 0 277 +277
Continue to review full report at Codecov.
|
Contributor
Author
|
Note: the large change in coverage is due to this PR enabling branch coverage, which is a stricter form of coverage many projects opt not to do. Also, their algorithm for counting branch partials is a little pessimistic IMO, but what can you do? |
Member
|
Seems pretty good, are there any downsides to this |
Contributor
Author
|
No downsides, just looks a little worse for us because branch coverage is more strict than line coverage. To give an example: |
Contributor
Author
|
@jacqueswww 👍 and can merge |
jacqueswww
approved these changes
Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.codecov.io/docs/about-code-coverage