Removed unnecessary JS file#1770
Merged
Merged
Conversation
fubuloubu
changed the title
Contributor
Author
|
Should remove lgtm JS analysis |
Codecov Report
@@ Coverage Diff @@
## master #1770 +/- ##
=======================================
Coverage 86.32% 86.32%
=======================================
Files 51 51
Lines 5980 5980
Branches 1553 1553
=======================================
Hits 5162 5162
Misses 530 530
Partials 288 288Continue to review full report at Codecov.
|
jacqueswww
approved these changes
Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out, the signing logic is tested with Python in
tests/examples/wallet/test_wallet.py, therefore the JS file is unnecessary