Bugfix - Importing an interface that contains an 'implements' statement#1774
Merged
fubuloubu merged 2 commits intoDec 22, 2019
Merged
Conversation
jacqueswww
approved these changes
Dec 20, 2019
Contributor
|
LGTM |
fubuloubu
approved these changes
Dec 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
When importing a Vyper contract as an interface, a
StructureExceptionis raised if that file includes animplementsstatement.How I fixed it
In
vyper/signatures/interface.py, I modifiedextract_sigsto exclude AST nodes related toimplements.How to verify it
Run the tests. I added a new test case around this behavior.
Cute Animal Picture