Unary operations on literals#1791
Merged
Merged
Conversation
fubuloubu
approved these changes
Dec 30, 2019
| decimal_divisor = Decimal('1e10') | ||
| min_decimal = (-2**127 + 1) / decimal_divisor | ||
| max_decimal = (2**127 - 1) / decimal_divisor | ||
| min_decimal = -2**127 + 1 |
Member
There was a problem hiding this comment.
this should just be -2**127
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixed some issues with negating constants.
The following example was failing because bounds checks caught
2**127as an overflow before applying the-:The following example was also failing with a clamping error:
How I did it
When an unary operation is applied to a constant, return the negated value without applying bounds checks on the original value.
How to verify it
Run the tests. I added some new test cases to verify that the issue is fixed.
Cute Animal Picture