Implement SHL/SHR for bitshifting#1796
Merged
Merged
Conversation
fubuloubu
approved these changes
Jan 2, 2020
fubuloubu
approved these changes
Jan 2, 2020
iamdefinitelyahuman
force-pushed
the
bitwise-ops
branch
from
b25c98e to
e3176e7
Compare
fubuloubu
approved these changes
Jan 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
SHL/SHRfor bitshifting when targeting>=constantinopleEVM ruleset - closes Reimplementshiftusing constantinople opcodes #1268How I did it
functions.functions.shift: When_shiftis a literal, do not includeIF SLT 0or resulting unreachable bytecode.How to verify it
Run the tests. I added some new test cases and parametrized existing ones.
Cute Animal Picture