Bugfix: returning tuples from private functions#1968
Merged
fubuloubu merged 2 commits intoMay 13, 2020
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1968 +/- ##
==========================================
- Coverage 86.99% 86.57% -0.42%
==========================================
Files 58 58
Lines 6629 6631 +2
Branches 1673 1674 +1
==========================================
- Hits 5767 5741 -26
- Misses 546 569 +23
- Partials 316 321 +5
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
May 13, 2020
fubuloubu
left a comment
Contributor
There was a problem hiding this comment.
Good set of tests here, I would like to see more, but this solves the bug for now.
e5533cc to
a2371f5
Compare
fubuloubu
approved these changes
May 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix a memory offset issue when returning tuple types from a private function.
Fixes #1847
How I did it
In
parser/self_call.py:mstorefor each value of an array inside a tuple.How to verify it
Run tests. I added some new cases.
Cute Animal Picture