Allow STATICCALL using raw_call#1973
Merged
fubuloubu merged 3 commits intoMay 15, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1973 +/- ##
=======================================
Coverage 87.16% 87.17%
=======================================
Files 58 58
Lines 6631 6636 +5
Branches 1674 1677 +3
=======================================
+ Hits 5780 5785 +5
Misses 536 536
Partials 315 315
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add
is_static_callkwarg toraw_callas a way to perform aSTATICCALL.Closes #1971
How I did it
Minor tweaks to the
RawCall.build_LLLlogic invyper/functions/functions.py:is_static_callandis_delegate_calltogether raisesraw_callmay now be used in@constantfunctions, ONLY whenis_static_call=True. If the kwarg is omitted, the exception message suggests it's use to the user.How to verify it
Run the tests. I added a few cases to verify that it works.
Cute Animal Picture