Fix memory length generated by assert_reason#1982
Merged
Merged
Conversation
Contributor
|
This looks right to me. A followup to my comments in #1981, I think we actually do need the |
Codecov Report
@@ Coverage Diff @@
## master #1982 +/- ##
=======================================
Coverage 87.17% 87.17%
=======================================
Files 58 58
Lines 6637 6637
Branches 1677 1677
=======================================
Hits 5786 5786
Misses 536 536
Partials 315 315
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
May 18, 2020
iamdefinitelyahuman
approved these changes
May 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1981
Description of issue
Code generation for
assert_reasongenerates incorrect length for revert string which leads to issues with revert reason decoding.How I fixed it
Fixed length of memory passed to revert opcode generated by assert_reason.
How to verify it
Check that assert tests are still passing.
Description for the changelog
Removed 32 bytes of junk at the end of revert reasons.
Cute Animal Picture