assert/raise modifications#2050
Merged
iamdefinitelyahuman merged 5 commits intoJun 26, 2020
Merged
Conversation
fubuloubu
approved these changes
Jun 26, 2020
iamdefinitelyahuman
force-pushed
the
assert-modifiable
branch
from
243cde4 to
5092063
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
assertstatementsassert_modifiablebuiltin functionraisewithout a reason, with a reason >32 chars long, or withUNREACHABLEThe documentation isn't perfect, but I plan to add a new section for statements where I'll end up rewriting all of this anyway.
Closes #1902
How to verify it
Run tests.
Cute Animal Picture